Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
j-zimnowoda
reviewed
Jan 28, 2026
Contributor
|
Comparison of Helm chart templating output: |
j-zimnowoda
reviewed
Jan 29, 2026
j-zimnowoda
reviewed
Jan 29, 2026
j-zimnowoda
approved these changes
Jan 29, 2026
Contributor
j-zimnowoda
left a comment
There was a problem hiding this comment.
I tested it and it works. Few comments added to be considered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Several of the automated PRs created by the CI action change little or nothing about the generated manifests. The utility script
bin/compare.shshows the differences, and the reviewer can merge such small patches without testing if there are no differences shown.The workflow is executed on every PR that has the label
chart-deps, and re-run on every commit except for merge commits.This PR also includes some fixes and tweaks for the
bin/compare.shscript:--diff-outputargument to specifically extract that part of the result and attach it to the PR. The entire output can still be seen in the job log, if needed.bin/compare.shandbin/dyff.shcan be copied to a different location for the purpose of testing, as running them changes the current branch.otomi.tsscript directly withnode, as using the bash script has caused issues.🔍 Reviewer Notes
An example run on this PR has been triggered. The diff is empty, but a sample run can be seen here: https://github.com/linode/apl-core/actions/runs/21440145048/job/61740795747?pr=2880
🧹 Checklist