Skip to content

ci: attach output comparison to automated PRs#2880

Merged
merll merged 33 commits intomainfrom
APL-1496
Jan 29, 2026
Merged

ci: attach output comparison to automated PRs#2880
merll merged 33 commits intomainfrom
APL-1496

Conversation

@merll
Copy link
Contributor

@merll merll commented Jan 28, 2026

📌 Summary

Several of the automated PRs created by the CI action change little or nothing about the generated manifests. The utility script bin/compare.sh shows the differences, and the reviewer can merge such small patches without testing if there are no differences shown.

The workflow is executed on every PR that has the label chart-deps, and re-run on every commit except for merge commits.

This PR also includes some fixes and tweaks for the bin/compare.sh script:

  • Quoting arguments
  • Fixing the output path of Helmfile
  • Adding a --diff-output argument to specifically extract that part of the result and attach it to the PR. The entire output can still be seen in the job log, if needed.
  • Save the script directory in a variable. This way, bin/compare.sh and bin/dyff.sh can be copied to a different location for the purpose of testing, as running them changes the current branch.
  • Calling the otomi.ts script directly with node, as using the bash script has caused issues.
  • Skipping hooks on changing branches, as this has further dependencies (e.g. nvm) which are not relevant for the comparison.

🔍 Reviewer Notes

An example run on this PR has been triggered. The diff is empty, but a sample run can be seen here: https://github.com/linode/apl-core/actions/runs/21440145048/job/61740795747?pr=2880

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@merll merll added the chart-deps Auto generated helm chart dependencies label Jan 28, 2026
@merll merll removed the chart-deps Auto generated helm chart dependencies label Jan 28, 2026
@merll merll changed the title ci: attach output comparision to automated PRs ci: attach output comparison to automated PRs Jan 28, 2026
@merll merll added the chart-deps Auto generated helm chart dependencies label Jan 28, 2026
@linode linode deleted a comment from svcAPLBot Jan 28, 2026
@svcAPLBot
Copy link
Contributor

Comparison of Helm chart templating output:


Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works. Few comments added to be considered.

@linode linode deleted a comment from svcAPLBot Jan 29, 2026
@linode linode deleted a comment from svcAPLBot Jan 29, 2026
@merll merll merged commit 0438eed into main Jan 29, 2026
12 checks passed
@merll merll deleted the APL-1496 branch January 29, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart-deps Auto generated helm chart dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants