Skip to content

feat: remove tempo app#2870

Merged
j-zimnowoda merged 3 commits intomainfrom
APL-1473
Jan 27, 2026
Merged

feat: remove tempo app#2870
j-zimnowoda merged 3 commits intomainfrom
APL-1473

Conversation

@j-zimnowoda
Copy link
Contributor

@j-zimnowoda j-zimnowoda commented Jan 26, 2026 •
edited
Loading

📌 Summary

Depends-on:
#2870
linode/apl-console#704
linode/apl-api#904

🔍 Reviewer Notes

For testing deployment set tag: APL-1473

kind: AplApp
metadata:
    name: otomi-console
spec:
    _rawValues:
        image:
            imagePullPolicy: Always
            repository: docker.io/linode/apl-console
            tag: APL-1473
...

kind: AplApp
metadata:
    name: otomi-api
spec:
    _rawValues:
        image:
            imagePullPolicy: Always
            repository: docker.io/linode/apl-api
            tag: APL-1473
...

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

This was referenced Jan 27, 2026
Merged
Merged
@merll
Copy link
Contributor

merll commented Jan 27, 2026

I am wondering if we should also remove the additional collector platform-otlp from values/otel-operator/otel-operator-raw.gotmpl and all related values with this. We are deploying this collector which without Tempo just writes everything back to stdout, and we provide no way of changing this.
If a platform admin ever would like to roll out their own tracing solution, they are better off setting up their own OTel collector, and then also have control of the pipeline.

CasLubbers
CasLubbers requested changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also maintain charts/grafana-dashboards. In there the tempo directory should also be removed it still contains the tempo dashboard.

@j-zimnowoda
Copy link
Contributor Author

j-zimnowoda commented Jan 27, 2026

We also maintain charts/grafana-dashboards. In there the tempo directory should also be removed it still contains the tempo dashboard.

Thanks. I have removed those as well.

@j-zimnowoda
Copy link
Contributor Author

j-zimnowoda commented Jan 27, 2026

I am wondering if we should also remove the additional collector platform-otlp from values/otel-operator/otel-operator-raw.gotmpl and all related values with this. We are deploying this collector which without Tempo just writes everything back to stdout, and we provide no way of changing this. If a platform admin ever would like to roll out their own tracing solution, they are better off setting up their own OTel collector, and then also have control of the pipeline.

Good point. Could you provide separate PR for removing that collector?

@j-zimnowoda j-zimnowoda merged commit ed0f77d into main Jan 27, 2026
12 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-1473 branch January 27, 2026 10:17
This was referenced Jan 27, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElderMatt ElderMatt ElderMatt approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@merll merll Awaiting requested review from merll merll is a code owner

@Ani1357 Ani1357 Awaiting requested review from Ani1357 Ani1357 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j-zimnowoda @merll @ElderMatt @CasLubbers