Skip to content

feat: optimize helm chart values for the argocd sync#2863

Merged
j-zimnowoda merged 10 commits intomainfrom
APL-1430
Jan 27, 2026
Merged

feat: optimize helm chart values for the argocd sync#2863
j-zimnowoda merged 10 commits intomainfrom
APL-1430

Conversation

@j-zimnowoda
Copy link
Contributor

@j-zimnowoda j-zimnowoda commented Jan 23, 2026 •
edited
Loading

📌 Summary

  • Yaml diff is sensitive to list order, thus sortAlpha
  • the --server-side argument ensures that Application does not have kubectl.kubernetes.io/last-applied-configuration which is lengthy and unnecessary
  • the revisionHistoryLimit set to 2 instead of 1=default 10, which aims limiting the size of argocd application status.history object
  • the sortTeamConfigArraysByName ensures that arrays of objects are sorted, so values for team-ns helm chart does not trigger faked argocd sync operation

🔍 Reviewer Notes

Some useful scripts to debug

kubectl get events -n argocd --field-selector involvedObject.kind=Application  --sort-by=.metadata.creationTimestamp | grep '> OutOfSync'

appName="team-alpha-team-ns-alpha"
kubectl get applications.argoproj.io  $appName -n argocd -o jsonpath='{.status.history[-1].source.helm.values}' > /tmp/history-1.yaml
kubectl get applications.argoproj.io  $appName -n argocd -o jsonpath='{.status.history[-2].source.helm.values}' >  /tmp/history-2.yaml
dyff between /tmp/history-1.yaml /tmp/history-2.yaml

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

CasLubbers
CasLubbers approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on cluster. Seeing only 2 history limit and now sorting issues found with team resources

@j-zimnowoda j-zimnowoda merged commit f135fb4 into main Jan 27, 2026
13 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-1430 branch January 27, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merll merll merll approved these changes

@ElderMatt ElderMatt ElderMatt approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@ferruhcihan ferruhcihan Awaiting requested review from ferruhcihan ferruhcihan is a code owner

@Ani1357 Ani1357 Awaiting requested review from Ani1357 Ani1357 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@j-zimnowoda @merll @ElderMatt @CasLubbers @svcAPLBot