Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes duplicate entries in the ArgoCD project's source repository list by deduplicating repository URLs before rendering them in the template. Previously, workloads sharing the same catalog URL would result in duplicate repository entries.
Key Changes:
- Collect all repository URLs (workload URLs, team repo, values repo) into a list
- Apply deduplication using the
uniqfunction before rendering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
merll
reviewed
Jan 8, 2026
merll
reviewed
Jan 8, 2026
Ani1357
approved these changes
Jan 9, 2026
Contributor
Ani1357
left a comment
There was a problem hiding this comment.
Tested by rendering locally and verified that there are no more duplicate entries
merll
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Many workloads can have exactly the same workload catalog. However the list of permitted source repositories should be contain only unique entries
🔍 Reviewer Notes
See the bin/compare.sh output
🧹 Checklist