feat: deploy secrets as secretRef in chart values#2805
Merged
j-zimnowoda merged 41 commits intomainfrom Jan 7, 2026
Merged
Conversation
added 17 commits
December 12, 2025 13:12
merll
reviewed
Dec 17, 2025
merll
reviewed
Dec 17, 2025
merll
previously requested changes
Dec 17, 2025
Contributor
merll
left a comment
There was a problem hiding this comment.
Requested changes as current implementation does not seem to work well when moving on to sealed secrets.
CasLubbers
reviewed
Dec 19, 2025
CasLubbers
approved these changes
Dec 19, 2025
j-zimnowoda
reviewed
Dec 30, 2025
j-zimnowoda
requested changes
Dec 30, 2025
Contributor
j-zimnowoda
left a comment
There was a problem hiding this comment.
I left one inline comment.
While running bin/compare.sh script I noticed that few Loki secretRefs are set to null which does not seem to be right.
spec.template.spec.containers.compactor
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
data.config.yaml
± value change in multiline text (one insert, one deletion)
- s3: https://someaccessKeyId:somesecretvalue@nl-ams-1.linodeobjects.com/my-clusterid-loki
+ s3: https://${S3_ACCESS_KEY_ID}:${S3_ACCESS_KEY_SECRET}@nl-ams-1.linodeobjects.com/my-clusterid-loki
spec.template.spec.containers.distributor
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
spec.template.spec.containers.ingester
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
spec.template.spec.containers.querier
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
spec.template.spec.containers.query-frontend
+ one map entry added:
envFrom:
- name: loki-s3-linode-credentials
│ secretRef: null
j-zimnowoda
reviewed
Jan 6, 2026
j-zimnowoda
reviewed
Jan 6, 2026
j-zimnowoda
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Replaces secrets withs secretRefs for Harbor and Oauth2-Proxy.
Uses environment Variables for Loki.