fix: duplicate credentials warning in Argocd#2796
Merged
j-zimnowoda merged 13 commits intomainfrom Dec 18, 2025
Merged
Conversation
Contributor
|
In this way of implementing common credentials, does this not counter measures of APL-527, where we try to eliminate secrets from values? |
merll
previously requested changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
I briefly checked branch APL-527 and it seems to me its goal conflicts with this change. Please align with @ElderMatt
ferruhcihan
approved these changes
Dec 18, 2025
ElderMatt
approved these changes
Dec 18, 2025
j-zimnowoda
reviewed
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
🔍 Reviewer Notes
🧹 Checklist