Conversation
2 tasks
Contributor
|
I think all the test files can be removed. |
ElderMatt
approved these changes
Nov 21, 2025
CasLubbers
reviewed
Nov 21, 2025
j-zimnowoda
reviewed
Nov 25, 2025
CasLubbers
approved these changes
Dec 1, 2025
Ani1357
pushed a commit
that referenced
this pull request
Jan 6, 2026
Co-authored-by: svcAPLBot <174728082+svcAPLBot@users.noreply.github.com> (cherry picked from commit 41187a2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR replaces hard-coded PostgreSQL parameters with platform values, which are identically set by default, but can be updated by the platform admin. Platform applications using PostgreSQL databases, i.e. Gitea, Keycloak, and Harbor also have the hard-coded connection pool settings replaced with variables. However, the defaults of maximum database connections on the app-side are reduced, for taking a deduction from the database
max_connectionsinto account.The default for
superuser_reserved_connectionsof 3. This has lead to Harbor not starting, when it was attempting to max out the connection pool.The max connections on the app-side is set to 28, considering the default of
superuser_reserved_connectionsplus one in case there are other maintenance connections. A backport for current releases, which does not involve schema changes, and just updates the hard-coded defaults, is published in #2731.Other changes to the schema are fixes of wrong locations or cleanups of unused values. In addition it showed that values introduced for each database's
backupSidecarResourceswere not applied in the template. This has been added here.🔍 Reviewer Notes
When upgrading to this feature branch, defaults should be added to the values repo. Changes are expected to require restarting the application pods, but not the databases as default settings are identical to current hard-coded parameters.
Note also when upgrading from
main, you need to setspecVersioninenv/settings/versions.yamlback to44for re-running schema migrations. Otherwise validations fail.🧹 Checklist