fix AcceptHttp being rebuilt for every connection#700
Merged
olix0r merged 1 commit intover/accept-profiles-tcp-splitfrom Oct 9, 2020
Merged
fix AcceptHttp being rebuilt for every connection#700olix0r merged 1 commit intover/accept-profiles-tcp-splitfrom
olix0r merged 1 commit intover/accept-profiles-tcp-splitfrom
Conversation
olix0r
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AcceptHttpservice is stateful. It builds the underlying HTTP,HTTP/2, and TCP service stacks lazily the first time they're needed.
This interacts badly with the derived implementation of
Clone: if it'scloned before the state is set, the state will only be set for the
clone, rather than for the original instance in the cache. Since
Prefixclones and oneshots the underlying service (AcceptHttp), thismeans that we rebuild the HTTP, HTTP/2, and TCP stacks on every
connection to the same orig dest. This basically breaks caching for
everything other than service profile discovery, causing us to do new
destination discovery for every connection to the same original
destination. Which...isn't great.
This branch fixes this issue by removing the
Cloneimpl fromAcceptHttpand putting it behind a buffer instead. In the future, itmay be possible to fix this in a nicer way, but this resolves the issue
for now.