feat(app/inbound): introduce request duration metrics#4432
Merged
Conversation
this commit introduces a new middleware layer to the inbound proxy. this instruments inbound traffic with Prometheus telemetry that records request body latency, and emits a histogram of request body durations. as in #4420, the buckets are chosen to mimic the request and response buckets emitted by the outbound proxy, with their granularity flipped. in other words, the inbound proxy is more interested in fine-grained request body metrics than response body metrics, while the outbound proxy is more interested in fine-grained response body metrics than request body metrics. * #4420 Signed-off-by: katelyn martin <kate@buoyant.io>
988b620 to
30a37c6
Compare
unleashed
approved these changes
Mar 4, 2026
Member
unleashed
left a comment
There was a problem hiding this comment.
Looks good, minor nits only 👍
> Doesn't this pull into scope and export both `MkLabelDuration` from `req_duration` and `rsp_duration`? - #4432 (comment) this commit avoids the potential for ambiguous reëxports by opting to refrain from `pub use` statements with wild cards. instead, we make submodules public, and update callsites (there are few) to refer to imports directly. Signed-off-by: katelyn martin <kate@buoyant.io>
#4432 (comment) Signed-off-by: katelyn martin <kate@buoyant.io>
#4432 (comment) Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit introduces a new middleware layer to the inbound proxy.
this instruments inbound traffic with Prometheus telemetry that records
request body latency, and emits a histogram of request body durations.
as in #4420, the buckets are chosen to mimic the
request and response buckets emitted by the outbound proxy, with their
granularity flipped. in other words, the inbound proxy is more
interested in fine-grained request body metrics than response body
metrics, while the outbound proxy is more interested in fine-grained
response body metrics than request body metrics.
Signed-off-by: katelyn martin kate@buoyant.io