refactor(http/prom): rename NewRecordBodyData::layer_via()#4199
Merged
refactor(http/prom): rename NewRecordBodyData::layer_via()#4199
NewRecordBodyData::layer_via()#4199Conversation
olix0r
approved these changes
Sep 30, 2025
sfleen
approved these changes
Sep 30, 2025
in #4174, we refactored this middleware so that it is now agnostic to the particular metrics structure used by the extractor, meaning that the constructor no longer accepts a `RequestBodyFamilies<L>` parameter. in the wake of this change, our request body frame size metrics middleware has a constructor with a type signature like `X -> impl Layer`. elsewhere throughout the project, constructors that accept an extractor and return a `svc::Layer` are typically called `layer_via()`. this commit renames `NewRecordBodyData::new()` to `NewRecordBodyData::layer_via()`. Signed-off-by: katelyn martin <kate@buoyant.io>
8142615 to
711715a
Compare
Member
Author
|
rebased on main to address conflicts with #4203. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #4174, we refactored this middleware so that it
is now agnostic to the particular metrics structure used by the
extractor, meaning that the constructor no longer accepts a
RequestBodyFamilies<L>parameter.in the wake of this change, our request body frame size metrics
middleware has a constructor with a type signature like
X -> impl Layer.elsewhere throughout the project, constructors that accept an extractor
and return a
svc::Layerare typically calledlayer_via().this commit renames
NewRecordBodyData::new()toNewRecordBodyData::layer_via().Signed-off-by: katelyn martin kate@buoyant.io