Conversation
this restructures `Permitted<T>` so that it is no longer an enum. we instead define a "dumb" enum that represents the grpc/http dichotomy, and return to a model in which `Permitted<T>` is a `struct`. Signed-off-by: katelyn martin <kate@buoyant.io>
in order to carve out space to allow us to define other `Param<P>` implementations for `Permitted<T>`, we remove this blanket deference to the inner `T` target. Signed-off-by: katelyn martin <kate@buoyant.io>
we cannot expose `T` or any of its own parameters, but we can expose the permit, its variant, and its labels. Signed-off-by: katelyn martin <kate@buoyant.io>
these now accept specifically the variant, rather than the permitted target. Signed-off-by: katelyn martin <kate@buoyant.io>
this type now can extract metrics from arbitrary targets. Signed-off-by: katelyn martin <kate@buoyant.io>
this type now can extract metrics from arbitrary targets. Signed-off-by: katelyn martin <kate@buoyant.io>
Signed-off-by: katelyn martin <kate@buoyant.io>
5cb38d8 to
8f8a5fe
Compare
olix0r
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4119 introduced a
Permitted<T>structure, to provide a more formal notion of a(HttpRoutePermit, T)tuple.during review of #4180, we had a discussion about how the inbound proxy's http router had metrics layers which were tightly coupled to the notion of a
Permitted<T>:this branch performs a series of changes to explore what appears to be a promising alternative to the existing model of
Permitted<T>. importantly, this has the effect of leaving the inbound metrics layers' extractors agnostic to their target: they now provide implementations likesvc::ExtractParam<BodyDataMetrics, T>rather thansvc::ExtractParam<BodyDataMetrics, Permitted<T>>.