chore(proxy/http): use hyper_util::rt::tokio::TokioExecutor
#3833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit removes the `linkerd-http-executor` crate, and replaces all usage of its `TracingExecutor` type with the `TokioExecutor` type provided by `hyper-util`. this work is based upon hyperium/hyper-util#166. that change, included in the 0.1.11 release, altered the `TokioExecutor` type so that it propagates tracing context when the `tracing` feature is enabled. with that change made, our `TracingExecutor` type is now redundant. * hyperium/hyper-util#166 * https://github.com/hyperium/hyper-util/blob/master/CHANGELOG.md#0111-2025-03-31 Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
commented
Apr 1, 2025
Comment on lines
+132
to
+135
| [workspace.dependencies.hyper-util] | ||
| version = "0.1" | ||
| default-features = false | ||
| features = ["tokio", "tracing"] |
Member
Author
There was a problem hiding this comment.
to prevent any footguns wherein we might neglect to set this feature flag, and inadvertently fail to propagate trace context, i've set this at the workspace level.
cratelyn
commented
Apr 1, 2025
cratelyn
commented
Apr 1, 2025
Comment on lines
+37
to
-42
| pub use hyper_util::rt::tokio::TokioExecutor; | ||
| pub use linkerd_http_box::{BoxBody, BoxRequest, BoxResponse, EraseResponse}; | ||
| pub use linkerd_http_classify as classify; | ||
| pub use linkerd_http_detect::{ | ||
| DetectMetrics, DetectMetricsFamilies, DetectParams, Detection, NewDetect, | ||
| }; | ||
| pub use linkerd_http_executor::TracingExecutor; |
Member
Author
There was a problem hiding this comment.
i've reexported this from linkerd-proxy-http, as we did for the previous executor.
i took the time to update callers to use the new name, rather than doing this under an alias. vim macros made this a straight-forward bit of work.
olix0r
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit removes the
linkerd-http-executorcrate, and replaces all usage of itsTracingExecutortype with theTokioExecutortype provided byhyper-util.this work is based upon hyperium/hyper-util#166. that change, included in the 0.1.11 release, altered the
TokioExecutortype so that it propagates tracing context when thetracingfeature is enabled.with that change made, our
TracingExecutortype is now redundant.