chore(proxy/http): replace hyper::Body with BoxBody#3480
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
#3482 tweaks the build script in question so that we'll get a better error in this situation in the future. |
`UpgradeResponseBody` currently wraps a `hyper::Body`. this type is removed in hyper 1.0. this commit replaces this with a generic `B`-typed body. see #3479, which performs the same change in `linkerd-http-upgrade`. see linkerd/linkerd2#8733 for more information on upgrading to hyper 1.0. Signed-off-by: katelyn martin <kate@buoyant.io>
cc13c01 to
a730c36
Compare
Member
Author
|
ci issues have resolved after rebasing this on the latest main. i'll mark comments above as resolved, and mark this as ready for review. |
olix0r
approved these changes
Jan 6, 2025
Member
olix0r
left a comment
There was a problem hiding this comment.
i'd expect that we can use hyper::body::Incoming here, but the box won't hurt us
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpgradeResponseBodycurrently wraps ahyper::Body. this type is removed in hyper 1.0.this commit replaces this with a generic
B-typed body.see #3479, which performs the same change in
linkerd-http-upgrade.see linkerd/linkerd2#8733 for more information on upgrading to hyper 1.0.