Split out failfast into smaller modules#2094
Merged
olix0r merged 6 commits intoeliza/failmasfrom Dec 28, 2022
Merged
Conversation
* Moved `Gate` into its own module. * Moved `test` into their own file. * Reorganized `Gate:poll_ready` slightly for clarity. * Added comments to `FailFast::poll_ready` state changes. * Renamed `max_unavailable` to `timeout`.
hawkw
approved these changes
Dec 28, 2022
Contributor
hawkw
left a comment
There was a problem hiding this comment.
splitting this up seems reasonable to me! i fixed some rustdoc warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateinto its own module.testinto their own file.Gate:poll_readyslightly for clarity.FailFast::poll_readystate changes.max_unavailabletotimeout.