Closed
Conversation
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Contributor
Author
|
The pre-install check output looks like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates
linkerd checkto accept a--preflag, which will cause the command to run a subset of checks to validate that linkerd can be installed (fixes #1470). It will also validate that the linkerd namespace does not already exist (fixes #1473).I made one additional change as part of this branch, which is to bypass the kubernetes server version check when running other linkerd subcommands. As it was previously written, those subcommands would preemptively fail if the kubernetes cluster did not meet the minimum required version. It seems better to let those commands run, and only warn in the check output if the minimum server version is not met.
Fixes #1470.
Fixes #1473.