Upgrade netty and boringssl versions #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Pretzer <charles@buoyant.io>
Member
|
As we discussed, let's investigate what it would take to get onto the latest finagle and netty 4.1.47: https://github.com/twitter/finagle/blob/develop/build.sbt#L9 |
Signed-off-by: Charles Pretzer <charles@buoyant.io>
adleong
reviewed
Apr 30, 2020
linkerd/protocol/h2/src/main/scala/io/buoyant/linkerd/protocol/H2Config.scala
Outdated
Show resolved
Hide resolved
linkerd/protocol/h2/src/main/scala/io/buoyant/linkerd/protocol/H2Config.scala
Outdated
Show resolved
Hide resolved
router/core/src/main/scala/com/twitter/finagle/buoyant/Dst.scala
Outdated
Show resolved
Hide resolved
router/core/src/main/scala/com/twitter/finagle/buoyant/Dst.scala
Outdated
Show resolved
Hide resolved
router/h2/src/main/scala/io/buoyant/router/h2/ClassifiedRetryFilter.scala
Outdated
Show resolved
Hide resolved
telemetry/core/src/main/scala/io/buoyant/telemetry/MetricsTreeStatsReceiver.scala
Show resolved
Hide resolved
telemetry/core/src/main/scala/io/buoyant/telemetry/MetricsTreeStatsReceiver.scala
Show resolved
Hide resolved
telemetry/statsd/src/main/scala/io/buoyant/telemetry/statsd/StatsDStatsReceiver.scala
Show resolved
Hide resolved
telemetry/statsd/src/main/scala/io/buoyant/telemetry/statsd/StatsDStatsReceiver.scala
Show resolved
Hide resolved
Signed-off-by: Charles Pretzer <charles@buoyant.io>
adleong
reviewed
Apr 30, 2020
telemetry/statsd/src/main/scala/io/buoyant/telemetry/statsd/StatsDStatsReceiver.scala
Show resolved
Hide resolved
Signed-off-by: Charles Pretzer <charles@buoyant.io>
zaharidichev
reviewed
May 1, 2020
finagle/h2/src/main/scala/com/twitter/finagle/buoyant/h2/netty4/Netty4DispatcherBase.scala
Outdated
Show resolved
Hide resolved
router/core/src/main/scala/com/twitter/finagle/buoyant/FailureAccrualFactory.scala
Outdated
Show resolved
Hide resolved
router/http/src/main/scala/io/buoyant/router/http/ContentLengthFilter.scala
Outdated
Show resolved
Hide resolved
finagle/buoyant/src/main/scala/com/twitter/finagle/buoyant/PathMatcher.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Charles Pretzer <charles@buoyant.io>
Signed-off-by: Charles Pretzer <charles@buoyant.io>
adleong
reviewed
May 5, 2020
Member
adleong
left a comment
There was a problem hiding this comment.
This looks good to me once CI is happy.
Contributor
Author
|
Thanks! I'm working on making CI happy now |
Signed-off-by: Charles Pretzer <charles@buoyant.io>
Contributor
Author
|
@adleong all checks are passing now :) |
Contributor
Author
|
fixes #2385 All tests have passed and this is ready to merge. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update netty to 4.1.46.Final and boringssl to 2.0.30.Final
H2FrameCodec has been updated to use the new ConnectionHandler() constructor which includes a boolean named
decoupleCloseAndGoAway. The netty PR adds functionality close the context and return ifdecoupleCloseAndGoAwayis true.This change defaults the value to false, which preserves the current Linkerd behavior.
Signed-off-by: Charles Pretzer charles@buoyant.io