Apply default socketoptions values when partial config is supplied. #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fantayeneh <fantayeneh@gmail.com>
zaharidichev
approved these changes
Aug 20, 2019
Member
zaharidichev
left a comment
There was a problem hiding this comment.
LGTM, apart from the build failure but by the looks of it, this appears to be a dependency resolution glitch. Thanks for your contribution!
|
|
||
| Stack.Params.empty + | ||
| Transport.Options(noDelay, reuseAddr, reusePort) + | ||
| Transport.Options(noDelay.getOrElse(true), reuseAddr.getOrElse(true), reusePort.getOrElse(false)) + |
Member
There was a problem hiding this comment.
I think it would be good form to put these in some constant such as DefaultNoDelay, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313
Signed-off-by: fantayeneh fantayeneh@gmail.com