Cherrypick: e24d82e0e#22
Merged
Merged
Conversation
KAFKA-7280; Synchronize consumer fetch request/response handling (apache#5495) This patch fixes unsafe concurrent access in the consumer by the heartbeat thread and the thread calling `poll()` to the fetch session state in `FetchSessionHandler`. Reviewers: Viktor Somogyi <viktorsomogyi@gmail.com>, Jason Gustafson <jason@confluent.io>
5547545 to
f1fe0c7
Compare
MayureshGharat
approved these changes
Apr 29, 2019
MayureshGharat
left a comment
There was a problem hiding this comment.
Open source has clearBufferedDataForUnassignedPartitions(...) instead of filterUnassignedPartitions(...) as is in Li/Kafka branch. I am not sure, why the naming is different internally, but this might cause conflicts for future merges. I don't want to block merging this patch, but thought that I should mention the concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherrypick contains merge conflict resolution as some of our patches are not available in upstream.
KAFKA-7280; Synchronize consumer fetch request/response handling (apache#5495)
Committer Checklist (excluded from commit message)