Skip to content

Upgrade Pre Assignment Clean Up To Remove Dependency Tasks Across Hosts#952

Merged
hshukla merged 2 commits intolinkedin:masterfrom
shrinandthakkar:upgradePreAssignmentCleanUp
Aug 29, 2023
Merged

Upgrade Pre Assignment Clean Up To Remove Dependency Tasks Across Hosts#952
hshukla merged 2 commits intolinkedin:masterfrom
shrinandthakkar:upgradePreAssignmentCleanUp

Conversation

@shrinandthakkar
Copy link
Copy Markdown
Collaborator

Summary

  • When a newly elected leader receives an instance-task assignment from ZK, it is expected that the leader will perform a cleanup routine on the assignment. Failure to do so may lead to inconsistencies in task assignment across instances.
  • At present, the pre-assignment cleanup only checks for dependency tasks in the current host's assignment and cleans them up accordingly. This process does not extend to other hosts, meaning that if the same task (a dependency list task) is assigned to another host, due to any unforeseen circumstances, it will not be cleaned up.
  • This is not a bug, rather it is a safety measure to restore the assignments in the event of a new leader being elected following a bad task assignment.

Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.

Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md

@shrinandthakkar shrinandthakkar marked this pull request as ready for review August 14, 2023 19:10
@shrinandthakkar shrinandthakkar force-pushed the upgradePreAssignmentCleanUp branch from b201215 to 99b91f3 Compare August 15, 2023 17:39
@shrinandthakkar shrinandthakkar requested a review from ehoner August 15, 2023 20:46
@hshukla hshukla merged commit 06fed5d into linkedin:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants