Add stop method to TransportProviderAdmin#944
Merged
vmaheshw merged 1 commit intolinkedin:masterfrom Jun 13, 2023
Merged
Conversation
jzakaryan
approved these changes
Jun 13, 2023
Collaborator
jzakaryan
left a comment
There was a problem hiding this comment.
LGTM. Just curious, are you going to override the stop method for one of the "fake" transport provider admins used in tests?
shrinandthakkar
approved these changes
Jun 13, 2023
Collaborator
Author
This is a problem for the Kafka Transport provider admins in the test and I will see what is the best way to fix the tests. In production, we don't need it as the JVM itself gets shutdown and there is no dangling resource, but for unit-tests, the dangling resource creates problem for other unit-test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some TransportProviderAdmins create AdminClient for Kafka and the lifecycle of the object is until the coordinator stops. Without a proper stop call for TransportProviderAdmin, the AdminClient loses connection to the other entities and result in failure for other unit-tests.