Skip to content

Add metrics for CoordinatorEvent queue#937

Merged
ehoner merged 9 commits intomasterfrom
DATAPIPES-26598
May 31, 2023
Merged

Add metrics for CoordinatorEvent queue#937
ehoner merged 9 commits intomasterfrom
DATAPIPES-26598

Conversation

@ehoner
Copy link
Copy Markdown
Contributor

@ehoner ehoner commented May 23, 2023

Adds a Gauge and Counter to CoordinatorEventBlockingQueue. The Gauge tracks the current size of the underlying queue; and the Counter increments when a duplicate event is put(). The class implements MetricsAware and registers the underlying metrics to the simple class name + constructor parameter key. The existing parameterless constructor is marked deprecated. It registers metrics to the key "CoordinatorEventBlockingQueue.legacy".

The change to MetricTestUtils was required to avoid collisions with TestCoordinator. The startsWith predicate was changed to match to ensure that the entire name was used to filter. The same metric verification registration test was added to the CoordinatorEventBlockingQueue.

jzakaryan
jzakaryan previously approved these changes May 25, 2023
Copy link
Copy Markdown
Collaborator

@jzakaryan jzakaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ehoner ehoner merged commit 6f59d2a into master May 31, 2023
@ehoner ehoner deleted the DATAPIPES-26598 branch May 31, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants