BMM Restart Improvements Part 4. Edge cases, cleanup and general improvements#924
Merged
jzakaryan merged 11 commits intolinkedin:masterfrom Feb 8, 2023
Merged
BMM Restart Improvements Part 4. Edge cases, cleanup and general improvements#924jzakaryan merged 11 commits intolinkedin:masterfrom
jzakaryan merged 11 commits intolinkedin:masterfrom
Conversation
ehoner
reviewed
Jan 31, 2023
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Show resolved
Hide resolved
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Show resolved
Hide resolved
ehoner
previously approved these changes
Feb 6, 2023
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Show resolved
Hide resolved
vmaheshw
reviewed
Feb 7, 2023
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Show resolved
Hide resolved
datastream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamStore.java
Outdated
Show resolved
Hide resolved
...-restli/src/main/java/com/linkedin/datastream/server/dms/ZookeeperBackedDatastreamStore.java
Outdated
Show resolved
Hide resolved
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Show resolved
Hide resolved
...-restli/src/main/java/com/linkedin/datastream/server/dms/ZookeeperBackedDatastreamStore.java
Outdated
Show resolved
Hide resolved
shrinandthakkar
approved these changes
Feb 8, 2023
vmaheshw
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of a series of changes that are meant to improve BMM Restart and make it easier to debug restart failures and trace them to the faulty hosts. Part 4 handles edge cases such as leader failover. It also introduces the following improvements suggested in the previous parts:
The PRs in this series deal with the following aspects:
Part 1 – Introduction of assignment tokens and support for issuing tokens by the leader coordinator (#919)
Part 2 – Changes to the followers' handleAssignmentChange to make them claim the tokens issued by the leader. (#921)
Part 3 – Changes to the leader to make it poll the ZooKeeper and wait for the assignment change (stop) to be propagated and executed by the cluster. ((#922)
Part 4 – Edge cases and cleanup and general improvements