Update zookeeper dependency to import from LinkedIn published version#917
Merged
jogrogan merged 3 commits intolinkedin:masterfrom Nov 30, 2022
Merged
Update zookeeper dependency to import from LinkedIn published version#917jogrogan merged 3 commits intolinkedin:masterfrom
jogrogan merged 3 commits intolinkedin:masterfrom
Conversation
Changing zookeeper import version and source. Change to importing from publicly available version published by LinkedIn instead of the version published from apache. Apache published version does not support pagination whereas the one published from LinkedIn does.
vmaheshw
previously approved these changes
Nov 15, 2022
jogrogan
previously approved these changes
Nov 15, 2022
Helix dependency transitively pulls zookeeper dependency from org.apache.zookeeper which conflicts with the zookeeper dependency from com.linkedin.zookeeper that we introduced for pagination support. We need to exclude this dependency globally. Updating major version because of zookeeper dependency group change
atoomula
previously approved these changes
Nov 21, 2022
hshukla
previously approved these changes
Nov 21, 2022
jogrogan
approved these changes
Nov 30, 2022
atoomula
approved these changes
Nov 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing zookeeper import version and source. Change to importing from publicly available version published by LinkedIn instead of the version published from apache. Apache published version does not support pagination whereas the one published from LinkedIn does.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md