Fixing test OnAssignmentChangeMultipleReassignments#908
Merged
shrinandthakkar merged 1 commit intolinkedin:masterfrom Jun 9, 2022
Merged
Fixing test OnAssignmentChangeMultipleReassignments#908shrinandthakkar merged 1 commit intolinkedin:masterfrom
shrinandthakkar merged 1 commit intolinkedin:masterfrom
Conversation
vmaheshw
approved these changes
Jun 9, 2022
surajkn
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the test OnAssignmentChangeMultipleReassignments by using the taskThreadDead parameter. After merging #877, we added a check to see if the task thread was dead before attempting to stop any task. We needed a respective fix in this test.
This test was added in a parallel running PR, hence it was missed when PR #877 fixed other similar tests.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md