Fix DPO unit test fail and refactor#554
Merged
Merged
Conversation
Contributor
|
thanks @Tcc0403 |
Collaborator
|
Can you raise this PR in LinkedIn? |
Collaborator
Author
|
@shivam15s do you mean linkedin branch? |
Collaborator
|
yep |
Collaborator
Author
|
@shivam15s It's on linkedin repo's branch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#521 introduced a unit test failure caused by the numerical issue in bf16.
This PR relaxes the atol for
chosen_rewardsandrejected_rewardsonly.Note: It's just a temporary fix for ci.
This PR also removes duplicated calculations on both terms.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence