Optimize & simplify Replace(char, char)#241
Merged
linkdotnet merged 3 commits intolinkdotnet:mainfrom Mar 3, 2025
Merged
Conversation
linkdotnet
reviewed
Feb 28, 2025
linkdotnet
reviewed
Feb 28, 2025
Contributor
Author
|
After benchmarking the optimization, I'm also reintroducing the optimization from my previous PR I closed:
This shows it's a good idea to simply use |
linkdotnet
approved these changes
Mar 1, 2025
Contributor
Author
Done finally ^-^ |
|
linkdotnet
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Replace(char, char). The built-in logic has low level optimizations on the buffer.ToValueStringBuilder(this StringBuilder)by passing setting the initial capacity to avoid growing the buffer.They're one PR because I was too lazy to make two.