Skip to content

Add Equals(ReadOnlySpan<char>, StringComparison)#234

Merged
linkdotnet merged 3 commits intolinkdotnet:mainfrom
Joy-less:add-equals-stringcomparison
Feb 16, 2025
Merged

Add Equals(ReadOnlySpan<char>, StringComparison)#234
linkdotnet merged 3 commits intolinkdotnet:mainfrom
Joy-less:add-equals-stringcomparison

Conversation

@Joy-less
Copy link
Copy Markdown
Contributor

Adds an equality comparison that has a StringComparison parameter. There are lots of other methods that would be nice on ValueStringBuilder that are available on span (such as StartsWith, EndsWith) but there would be so much to add it would likely be best to leave them available through AsSpan(). This one is just an overload for an existing method tho.

Copy link
Copy Markdown
Owner

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be lovely to add an entry to the CHANGELOG.md.

@Joy-less
Copy link
Copy Markdown
Contributor Author

Would be lovely to add an entry to the CHANGELOG.md.

Done

@Joy-less Joy-less force-pushed the add-equals-stringcomparison branch from d303710 to dff02a5 Compare February 16, 2025 04:23
@linkdotnet linkdotnet merged commit dd39217 into linkdotnet:main Feb 16, 2025
@sonarqubecloud
Copy link
Copy Markdown

@Joy-less Joy-less deleted the add-equals-stringcomparison branch February 16, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants