Skip to content

Short-circuit empty span#233

Merged
linkdotnet merged 3 commits intolinkdotnet:mainfrom
Joy-less:short-circuit-empty-span
Feb 16, 2025
Merged

Short-circuit empty span#233
linkdotnet merged 3 commits intolinkdotnet:mainfrom
Joy-less:short-circuit-empty-span

Conversation

@Joy-less
Copy link
Copy Markdown
Contributor

Performance optimisation when span is empty. StringBuilder also does this.

@linkdotnet
Copy link
Copy Markdown
Owner

Performance optimisation when span is empty. StringBuilder also does this.

Interesting. I initially thought about that but then decided to shift the responsibility to the caller. Let's roll with it

@sonarqubecloud
Copy link
Copy Markdown

@linkdotnet linkdotnet merged commit 07afdad into linkdotnet:main Feb 16, 2025
@Joy-less Joy-less deleted the short-circuit-empty-span branch February 16, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants