Skip to content

report coverage to Coveralls#41

Merged
anarcat merged 1 commit intolinkchecker:masterfrom
PetrDlouhy:feature/coveralls
Feb 14, 2017
Merged

report coverage to Coveralls#41
anarcat merged 1 commit intolinkchecker:masterfrom
PetrDlouhy:feature/coveralls

Conversation

@PetrDlouhy
Copy link
Copy Markdown
Contributor

This repo must be enabled on Coveralls

tox.ini Outdated
pytest-cov
commands =
py.test {posargs:--tb=short tests}
py.test {posargs:--tb=short --cov=linkcheck" tests}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this introduces a syntax error that makes tests fail, i believe.

@mgedmin
Copy link
Copy Markdown
Contributor

mgedmin commented Feb 13, 2017

👍 (after the typo is fixed)

@PetrDlouhy
Copy link
Copy Markdown
Contributor Author

The typo is fixed, but the repo is not enabled on Coveralls, so the report is not visible.

@mgedmin
Copy link
Copy Markdown
Contributor

mgedmin commented Feb 14, 2017

I think @anarcat is the only one who can enable https://coveralls.io integration.

(I use coveralls.io on a few of my other projects, but I don't have the permissions to enable it for this one. I'm not sure what permission exactly is missing, I just know that this organisation doesn't show up for me in the Coveralls UI.)

@anarcat
Copy link
Copy Markdown
Contributor

anarcat commented Feb 14, 2017

@mgedmin that's it, you're promoted to owner. ;)

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 271c592 on PetrDlouhy:feature/coveralls into ** on linkcheck:master**.

@mgedmin
Copy link
Copy Markdown
Contributor

mgedmin commented Feb 14, 2017

Coveralls are enabled. I've restarted the Travis build to re-trigger the coverage data upload. You can see a report at https://coveralls.io/github/linkcheck/linkchecker.

The badge will show "unknown" until this PR is merged to master:
Coverage Status

@anarcat: only your review is blocking this merge now.

@mgedmin
Copy link
Copy Markdown
Contributor

mgedmin commented Feb 14, 2017

(I've now turned off those annoying coveralls comments on pull requests.)

@mgedmin
Copy link
Copy Markdown
Contributor

mgedmin commented Feb 14, 2017

I've asked Coveralls to indicate a build failure if coverage decreases by 1%.

I'm curious: @anarcat, can you access https://coveralls.io/github/linkcheck/linkchecker/settings ? If you've never used coveralls before, it's useful to know that you can log in using your GitHub account via some OAUTH magic. I'd also be curious to know if you have to go to your GitHub profile settings and grant the Coveralls application access to the linkcheck organization (I've done this, but I don't know if that's a global thing or something for each GitHub user who wants to log in to Coveralls).

@anarcat
Copy link
Copy Markdown
Contributor

anarcat commented Feb 14, 2017 via email

@mgedmin
Copy link
Copy Markdown
Contributor

mgedmin commented Feb 14, 2017

Repeating so this doesn't get lost: @anarcat: only your review is blocking this merge now. ;)

@anarcat anarcat merged commit a48d37f into linkchecker:master Feb 14, 2017
@mgedmin mgedmin changed the title report coverate to Coveralls report coverage to Coveralls Apr 24, 2019
@mgedmin mgedmin mentioned this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants