Conversation
This was referenced Apr 25, 2019
anarcat
approved these changes
Apr 27, 2019
Contributor
anarcat
left a comment
There was a problem hiding this comment.
LGTM. I have frankly zero idea why the hell we're doing telnet in linkchecker in the first place, but might as well fix this.
Linkchecker's telnet://username:password@host:port URL verification logic is - connect to host:port - wait for 'login: ' to appear (with a 10 second timeout), send username - wait for 'Password: ' to appear (with a 10 second timeout), send password The test spawns a fake telnet server on localhost that never presented the login/password prompts, forcing the 10 second timeout three times. This commit makes the fake telnet server emit the expected prompts, making the test pass in .2 seconds.
505940a to
947b108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linkchecker's telnet://username:password@host:port URL verification logic is
The test spawns a fake telnet server on localhost that never presented
the login/password prompts, forcing the 10 second timeout three times.
This commit makes the fake telnet server emit the expected prompts,
making the test pass in .2 seconds.