Skip to content

Make test_all_parts TestLogger import Python 3 compatible#252

Merged
anarcat merged 1 commit intolinkchecker:masterfrom
cjmayo:init
Apr 25, 2019
Merged

Make test_all_parts TestLogger import Python 3 compatible#252
anarcat merged 1 commit intolinkchecker:masterfrom
cjmayo:init

Conversation

@cjmayo
Copy link
Copy Markdown
Contributor

@cjmayo cjmayo commented Apr 25, 2019

tests/checker/test_all_parts.py:21: in
import init as init
E ModuleNotFoundError: No module named 'init'

testWarning: cannot collect test class 'TestLogger' because it has a
init constructor

tests/checker/test_all_parts.py:21: in <module>
    import __init__ as init
E   ModuleNotFoundError: No module named '__init__'

testWarning: cannot collect test class 'TestLogger' because it has a
__init__ constructor
@cjmayo cjmayo mentioned this pull request Apr 25, 2019
Copy link
Copy Markdown
Contributor

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"""

# don't attempt to collect this class because it has an __init__()
__test__ = False
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anarcat anarcat merged commit 095c6c5 into linkchecker:master Apr 25, 2019
@anarcat
Copy link
Copy Markdown
Contributor

anarcat commented Apr 25, 2019

i frankly have no idea what's going on here, but i'll trust this will not backdoor my machine. :p

@cjmayo cjmayo deleted the init branch November 21, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants