{python3_13} Python3: fix imports in test_noproxy#223
Merged
anarcat merged 1 commit intolinkchecker:masterfrom Apr 24, 2019
Merged
{python3_13} Python3: fix imports in test_noproxy#223anarcat merged 1 commit intolinkchecker:masterfrom
anarcat merged 1 commit intolinkchecker:masterfrom
Conversation
mgedmin
reviewed
Apr 11, 2019
tests/checker/test_noproxy.py
Outdated
| """ | ||
| import httpserver | ||
| from test.test_support import EnvironmentVarGuard | ||
| from .import httpserver |
Contributor
There was a problem hiding this comment.
I think PEP-8 wants this to be from . import httpserver.
Closed
Contributor
Author
|
@mgedmin please confirm OK. |
mgedmin
approved these changes
Apr 24, 2019
Contributor
mgedmin
left a comment
There was a problem hiding this comment.
LGTM!
(I appreciate the pings and apologize for making you wait for like a week.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.