WIP: Python3: update makefiles to test in Python 3 in allow-failures mode#211
WIP: Python3: update makefiles to test in Python 3 in allow-failures mode#211cjmayo wants to merge 1 commit intolinkchecker:masterfrom
Conversation
| LEX = flex | ||
| YACC = bison | ||
| PYINCLUDE=-I/usr/include/python2.7 | ||
| PYINCLUDE=-I/usr/include/python |
There was a problem hiding this comment.
FWIW my machine (Ubuntu 18.10) does not have a /usr/include/python. It has /usr/include/python2.7 and /usr/include/python3.* for various values of *.
I wonder if we should maybe use something like $(pkg-config --cflags python) (which on my machine prints -I/usr/include/python2.7 -I/usr/include/x86_64-linux-gnu/python2.7)?
(Or we could merge that PR that replaces linkcheck/HtmlParser with BeautifulSoup.)
There was a problem hiding this comment.
I don't have /usr/include/python either, and nor does pkg-config --cflags python work. Supporting both Python 2 and 3 is complicated, and varies between distrubutions...
On the other hand, what does this file need to do? Supply a clean instruction? Run the awk?
Because setup.py does seem to do the actual building using Extension - which is the bit that needs the include.
|
Suggest closing this one without merging. Project is building fine from |
|
i'd like to get rid of the Makefile altogether, if it's not useful. this can (and should) all be replaced by setup.py stuff, IMHO. yet this probably doesn't block py3 porting, so keeping this open until someone deals with the Makefile (or opens a more targeted issue to do so). |
|
This one also for the record: Line 5 in 9d57bee Called by top-level |
I like Makefiles, but I don't have the energy to investigate this. +1 for closing (or even removing the Makefile entirely). (IMHO in a Python project Makefiles are primarily a tool for maintainers. They make sense when the maintainer finds them useful. I find them useful: all of my personal Python projects have a Makefile that lets me do things like |
Yep, done.
While I understand where this is coming from, adding Make as a dependency to a project, even if only for maintenance, adds yet another hurdle to adoption for new people. They need to learn another tool that's not part of the standard programming environment. Python (and especially distutils and friends) is complicated enough without having people figure out Make on top of that... I would actually agree if Makefiles were used as tiny wrappers on top of This is arguably because packaging is too hard in Python. But that's being improved and we should follow that instead of hiding it under a layer of Makefile-ing. So while I also do like Makefiles and use them often, I think that, in our case, we should totally get rid of it and do everything in setup.py, like good Python citizens. ;) But until we go there, i think this can be closed as well. :) |
No description provided.