Require requests >= 2.4#147
Conversation
This is already in the code in `linkcheck/__init__.py`, update the requirements and setup file so it can be installed via `pip`.
anarcat
left a comment
There was a problem hiding this comment.
i may have lost track but in #66 we deliberately limited the dependency to <2.15 because of a compatibility problem described in #76. but considering tests pass here I'm not sure what's going on here...
shouldn't we keep the <2.15 dependency? what actually happens when you try to install through pip now?
|
and yes, this is a mess, sorry! |
|
It fails when installed via pip on Ubuntu Trusty (that's what Travis uses):
I have no idea if it'd work when keeping other constraint, sorry. I'm just copy&pasting stuff to get it working for the restic website ;) |
|
right okay. i took the liberty of editing your branch to restore the other limit, could you test the result and see if it works for you? |
|
Sure |
|
Seems to work, pip installs a newer version of requests :) |
|
awesome, LGTM then.. :) glad to see you use linkchecker and thanks for the contribution! |
|
( @mgedmin it would be nice to cleanup those requirements and specify them just in one place... do you have a quick trick up your sleeves on how to do that? i always wonder why we need the .txt file in the first place...) |
|
Cool, I like linkchecker, it does what it should. But I spent two hours fighting the old Python 2.7 (without SNI support 😞) on Travis on Ubuntu Trusty. That was not fun at all |
|
yeah, this thing is really showing its age. this is only what you see as a user, as a developer there are much worse horrors lurking below, e.g. #119 |
|
WTF? There's an HTML parser in this project? Written in C? Oh well. That was... unexpected... |
|
welcome to my world of wonders.
|
|
TBH I think It is currently used in tox.ini (redundant, except for the 'argcomplete' dependency that tox wouldn't otherwise pick up as it's missing from install_requires), and mentioned in a couple of files in |
|
@mgedmin let's remove it then, do you mind filing a pr? |
|
Then I would have to come up with documentation updates... I don't have the energy for that at the moment. :( |
|
i understand, no problem. |
This is already in the code in
linkcheck/__init__.py, update the requirements and setup file so it can be installed viapip.