(Not to be pulled) Charset tests#125
Closed
PetrDlouhy wants to merge 2 commits intolinkchecker:masterfrom
Closed
Conversation
f600e43 to
8d3c3dd
Compare
it probably works now without the conversion
8d3c3dd to
b898ed5
Compare
Closed
Contributor
Ouch. Well, I guess that offsets my other concerns. ;) Good to know, thanks!! |
Contributor
|
The charset tests commit is included in #337 (and has been very useful in developing that). |
Contributor
|
Tests merged into master d1844a5. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So about the encoding. It doesn't work in current implementation of Linkchecker at all.
I would expect, it translates the encoding from the original one to the encoding of the terminal. Or it translates the characters to the form, that one could easily read. (Like
Zlutoucky kun upel dabelske ody uuuu). It does neither of that. It just outputs the link name in original form on the terminal, which will lead to unreadable characters.This PR is not meant to be pulled, but it could serve as reference before implementing character handling fixes (i.e. during the parser change).