Remove third party libraries from repository#118
Merged
anarcat merged 1 commit intolinkchecker:masterfrom Jan 10, 2018
Merged
Conversation
0d57686 to
f04873b
Compare
Closed
anarcat
approved these changes
Jan 6, 2018
Contributor
anarcat
left a comment
There was a problem hiding this comment.
niiice. I can't say that's i've reviewed every line of this change, but removing code is always good, so LGTM. :)
mgedmin
approved these changes
Jan 9, 2018
Contributor
mgedmin
left a comment
There was a problem hiding this comment.
Mostly LGTM.
I think you should add dnspython to install_requires in setup.py. requirements.txt will not be used when people pip install linkchecker2 (assuming we ever manage to release it to PyPI).
f04873b to
0a13fae
Compare
Contributor
Author
|
OK, I've added |
Contributor
|
okay well, i've merged this. fire in the hole! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes third party libraries from the sources and uses them as dependency.