Skip to content

chore: remove CRA, write tests for vite-babel example, correct macro exports#2432

Merged
andrii-bodnar merged 5 commits intonextfrom
chore/remove-cra
Feb 4, 2026
Merged

chore: remove CRA, write tests for vite-babel example, correct macro exports#2432
andrii-bodnar merged 5 commits intonextfrom
chore/remove-cra

Conversation

@timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Feb 4, 2026

Description

This PR removes CRA from examples, and add E2E testing for vite-babel-example

Closes #2411
unblocks #2430

I also added build and extract commands to the workflow, just to smoke test that they are working fine.

Important:

I also found that exports for /macro in both react and core was incorrect. Tests i created caught that. I fixed the issue in that PR as well.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
js-lingui Ready Ready Preview Feb 4, 2026 10:49am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

size-limit report 📦

Path Size
packages/core/dist/index.mjs 1.77 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.21 KB (0%)

@timofei-iatsenko timofei-iatsenko changed the title chore: remove CRA, write tests for vite-babel example chore: remove CRA, write tests for vite-babel example, correct macro exports Feb 4, 2026
@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review February 4, 2026 10:53
@andrii-bodnar andrii-bodnar added this to the v6 milestone Feb 4, 2026
@andrii-bodnar andrii-bodnar merged commit dc52f6d into next Feb 4, 2026
10 checks passed
@andrii-bodnar andrii-bodnar deleted the chore/remove-cra branch February 4, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants