refactor: modernize format-po-gettext#2428
Merged
andrii-bodnar merged 7 commits intonextfrom Feb 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
| "esModuleInterop": true, | ||
| "stripInternal": true, | ||
| "noUnusedLocals": true, | ||
| "resolveJsonModule": true, |
Collaborator
Author
There was a problem hiding this comment.
this is intentional, i don't want typescript to read and analyze big json files, it's slows it down
andrii-bodnar
requested changes
Jan 30, 2026
Co-authored-by: Andrii Bodnar <andrii.bodnar@crowdin.com>
andrii-bodnar
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the TypeScript
strict: trueoption and fixes all issues introduced by this change.I also removed the
node-gettextpackage, which we previously used to obtain gettext plural formulas, and replaced it with a static JSON file generated using the gettext/Languages project.I added a github workflow, which should check for the updates in CLDR once a month and create a PR. I tested with pull_request trigger before switching to cron.
Since the generated JSON also contains plural samples and case names (one, few, many, etc.), I was able to remove the
cldr-coreandplurals-cldrpackages and simplify the “generate samples” implementation.Additionally, I extracted some utilities whose implementations I wasn’t fully confident in and covered them with their own set of tests.
There is still room for improvement, but this should be good enough for now.
This PR introduces no breaking changes; the functionality remains the same.
Types of changes
Fixes # (issue)
Checklist