Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
andrii-bodnar
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Chokidar changelog (we used v3):
v4 - removed glob support
v5 - rewrite to ESM
This PR updates to v5, and bringing back watching by glob.
I started from writing test, coz, this functionality was not covered, and found some minor issues which are fixed now.
I've found that compile watcher did not react on the new catalog file adding, this PR does not fix that, and i think it's fine since nobody complained (creating new catalogs should be quite rear operation + watchers are also rarely used in lingui)
With current chokidar implementation to watch for catalog creation we need to add watcher to the entire
rootDirwhich might be suboptimal in terms of amount of fs watchers. So proper fix is not straightforward.Anyway this PR focused on updating an outdated dependency.
Also i bumped typescript target es2023, since supported by lingui nodejs version (20.*) support all features up to that spec https://node.green/#ES2023
Types of changes
Fixes # (issue)
Checklist