Skip to content

chore: bump chokidar@5 & ora@9#2416

Merged
andrii-bodnar merged 7 commits intonextfrom
bump-chokidar
Jan 27, 2026
Merged

chore: bump chokidar@5 & ora@9#2416
andrii-bodnar merged 7 commits intonextfrom
bump-chokidar

Conversation

@timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Jan 27, 2026

Description

Chokidar changelog (we used v3):

v4 - removed glob support
v5 - rewrite to ESM

This PR updates to v5, and bringing back watching by glob.

I started from writing test, coz, this functionality was not covered, and found some minor issues which are fixed now.

I've found that compile watcher did not react on the new catalog file adding, this PR does not fix that, and i think it's fine since nobody complained (creating new catalogs should be quite rear operation + watchers are also rarely used in lingui)

With current chokidar implementation to watch for catalog creation we need to add watcher to the entire rootDir which might be suboptimal in terms of amount of fs watchers. So proper fix is not straightforward.

Anyway this PR focused on updating an outdated dependency.

Also i bumped typescript target es2023, since supported by lingui nodejs version (20.*) support all features up to that spec https://node.green/#ES2023

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
js-lingui Ready Ready Preview Jan 27, 2026 3:19pm

Request Review

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

size-limit report 📦

Path Size
packages/core/dist/index.mjs 1.77 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.21 KB (0%)

@timofei-iatsenko timofei-iatsenko changed the title chore: Bump chokidar@5 chore: Bump chokidar@5 && ora@9 Jan 27, 2026
@timofei-iatsenko timofei-iatsenko changed the title chore: Bump chokidar@5 && ora@9 chore: bump chokidar@5 & ora@9 Jan 27, 2026
@andrii-bodnar andrii-bodnar merged commit a3ca756 into next Jan 27, 2026
9 checks passed
@andrii-bodnar andrii-bodnar deleted the bump-chokidar branch January 27, 2026 15:27
@andrii-bodnar andrii-bodnar added this to the v6 milestone Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants