Skip to content

refactor: align translationio integration with code standarts#2388

Merged
andrii-bodnar merged 13 commits intolingui:mainfrom
timofei-iatsenko:refactor/translation-io-integration
Jan 23, 2026
Merged

refactor: align translationio integration with code standarts#2388
andrii-bodnar merged 13 commits intolingui:mainfrom
timofei-iatsenko:refactor/translation-io-integration

Conversation

@timofei-iatsenko
Copy link
Collaborator

Description

  • Covered everything with integration and unit tests
  • Improved TypeScript type safety
  • Switched to more modern APIs and language constructs

More importantly, I replaced the duplicated implementations with Lingui internals for:

  • discovering the catalogs path
  • serializing/deserializing catalogs

This means the integration is now fully aligned with Lingui itself and should support more of Lingui’s functionality out of the box.

Among others:

  • Support different formatters, not only PO
  • Support settings defined in the formatter (line numbers support, etc)
  • Fully support multiple catalogs defined in the lingui config
  • Support catalogs defined by experimental (deps) extractor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2380

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jan 7, 2026

@timofei-iatsenko is attempting to deploy a commit to the Crowdin Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 82.72727% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.36%. Comparing base (6bb8983) to head (ae94399).
⚠️ Report is 254 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/services/translationIO.ts 80.32% 5 Missing and 7 partials ⚠️
...i/src/services/translationIO/segment-converters.ts 87.80% 0 Missing and 5 partials ⚠️
...li/src/services/translationIO/translationio-api.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
+ Coverage   77.05%   81.36%   +4.31%     
==========================================
  Files          84      102      +18     
  Lines        2157     2716     +559     
  Branches      555      723     +168     
==========================================
+ Hits         1662     2210     +548     
+ Misses        382      362      -20     
- Partials      113      144      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timofei-iatsenko timofei-iatsenko force-pushed the refactor/translation-io-integration branch from e959c28 to ae94399 Compare January 15, 2026 10:52
@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review January 16, 2026 14:40
@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
js-lingui Ready Ready Preview Jan 20, 2026 1:42pm

Request Review

@andrii-bodnar andrii-bodnar merged commit bec3199 into lingui:main Jan 23, 2026
11 checks passed
@timofei-iatsenko timofei-iatsenko deleted the refactor/translation-io-integration branch January 23, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aligning translationIo integration with LinguiJS code standards

2 participants