Conversation
|
@yslpn is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
…CallbackOrComponent
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 77.05% 76.61% -0.44%
==========================================
Files 84 100 +16
Lines 2157 2745 +588
Branches 555 715 +160
==========================================
+ Hits 1662 2103 +441
- Misses 382 513 +131
- Partials 113 129 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "peerDependencies": { | ||
| "@lingui/babel-plugin-lingui-macro": "5.7.0", | ||
| "babel-plugin-macros": "2 || 3", | ||
| "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0" |
There was a problem hiding this comment.
technically speaking, this is a breaking change. Nothing wrong with that. But I say.. let's bump this to 18 and stop caring about the old versions
There was a problem hiding this comment.
I agree with you. If we upgraded React, we could use useSyncExternalStore to sync react state with i18n state. It's a simpler and more performant option than using useEffect.
But I need other contributors' agreement that we're ready to upgrade React to version 18.
There was a problem hiding this comment.
@andrii-bodnar @timofei-iatsenko
What do you think about raising the React version to 18?
There was a problem hiding this comment.
I'm not sure about rising the version to 18. There is no real need for that. I'm ok with rising react version to 16.14.
I'm also thinking that despite technically it's a breaking change we can release it without a new major version. It is not requiring react to be bumped to next major, so users may easy bump their projects to 16.14.0
There was a problem hiding this comment.
we can release it without a new major version.
agree with you
|
@andrii-bodnar please add that consumers need to bump their react dependency to at least |
|
Yeah, I am going to mention this in the release description |
Description
Switch React packages to the automatic JSX runtime: Babel/esbuild now emit JSX without explicit
Reactimports, and the React tsconfig usesreact-jsx. Raised the minimum supportedreactpeer to16.14.0to align with the automatic runtime requirements. This follows the guidance in the new JSX transform announcement: https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.htmlTypes of changes
Fixes # N/A
Checklist