chore!: replace cosmiconfig with lilconfig in configuration handling#2286
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2286 +/- ##
===========================================
+ Coverage 76.66% 87.82% +11.15%
===========================================
Files 81 113 +32
Lines 2083 3301 +1218
Branches 532 969 +437
===========================================
+ Hits 1597 2899 +1302
+ Misses 375 362 -13
+ Partials 111 40 -71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Lilconfig is smaller mostly because it doesn't have a yaml parser in it. And it means no yaml configuration files would be supported. Despite the fact that i removed all mentions of yaml config from docs, technically it still a breaking change. |
You are right. But then I suggest adding yaml support via a separate module and adding deprecation warning. |
|
@yslpn i'm proposing to include this into upcoming v6. Please reopen that PR and change target to the "next" branch. Also it's now safe to drop yaml support. |
|
@yslpn is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
|
@yslpn i'm also looking into https://www.npmjs.com/package/c12 may be it worth changing? (mjs, ts, etc) supported out of the box, without extra configuration on lingui side, wdyt? Have you looked into this one? |
I haven't seen a package like this before. Thank you. But I like lilconfig because it doesn't have many features and no dependencies. c12 has 12 dependencies. Furthermore, c12 has a fully asynchronous API, so a lot of changes will be required. |
|
@yslpn could you rebase (or merge) this branch onto |
@timofei-iatsenko Done |
|
@yslpn @andrii-bodnar LGTM, could be merged |
Description
Replace cosmiconfig with lilconfig. A zero-dependency alternative with the same API. Comparison: https://node-modules.dev/#install=cosmiconfig vs https://node-modules.dev/#install=lilconfig
Support for Yaml configs has been removed.
Types of changes
Checklist