Skip to content

fix(cli): allow using PO formatter function with Translation.IO#2375

Merged
andrii-bodnar merged 3 commits intolingui:mainfrom
andrejcremoznik:fix/2374-translationio-cli
Dec 10, 2025
Merged

fix(cli): allow using PO formatter function with Translation.IO#2375
andrii-bodnar merged 3 commits intolingui:mainfrom
andrejcremoznik:fix/2374-translationio-cli

Conversation

@andrejcremoznik
Copy link
Copy Markdown
Contributor

@andrejcremoznik andrejcremoznik commented Dec 3, 2025

Description

Translation.io sync checks if config.format === 'po' which is insufficient because the formatter can also be the function exported from the format-po package.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2374

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 3, 2025

@andrejcremoznik is attempting to deploy a commit to the Crowdin Team on Vercel.

A member of the Team first needs to authorize it.

@andrii-bodnar andrii-bodnar mentioned this pull request Dec 3, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.22%. Comparing base (6bb8983) to head (afdadde).
⚠️ Report is 240 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/services/translationIO.ts 0.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2375      +/-   ##
==========================================
- Coverage   77.05%   76.22%   -0.83%     
==========================================
  Files          84      100      +16     
  Lines        2157     2663     +506     
  Branches      555      695     +140     
==========================================
+ Hits         1662     2030     +368     
- Misses        382      509     +127     
- Partials      113      124      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timofei-iatsenko timofei-iatsenko self-requested a review December 10, 2025 15:21
@timofei-iatsenko
Copy link
Copy Markdown
Collaborator

timofei-iatsenko commented Dec 10, 2025

@andrii-bodnar @andrejcremoznik LGTM

@andrii-bodnar andrii-bodnar merged commit f8b90e2 into lingui:main Dec 10, 2025
9 of 11 checks passed
@didier-84
Copy link
Copy Markdown
Contributor

didier-84 commented Dec 10, 2025

@andrii-bodnar @timofei-iatsenko @andrejcremoznik Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timofei-iatsenko timofei-iatsenko timofei-iatsenko approved these changes

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatibility of PO function formatter with Translation.io

4 participants

@andrejcremoznik @timofei-iatsenko @didier-84 @andrii-bodnar