fix(macro): recrawl scope only if useLingui was used#2370
Merged
andrii-bodnar merged 1 commit intomainfrom Nov 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
2 tasks
andrii-bodnar
approved these changes
Nov 25, 2025
Contributor
andrii-bodnar
left a comment
There was a problem hiding this comment.
@timofei-iatsenko thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Probably i introduced a huge performance regression when added scope recrawling in #2356
The scope recrawling happened for all
CallExpression|TaggedTemplateExpressiondespite was it a macro or not, or was it a useLingui hook which actually need a recrawling a bindnings.This PR fixes that by moving scope recrawling to only when
useLinguihook was transpiled.Types of changes
Potentially fixes #2369
Checklist