Refactor tracing handling for events#688
Merged
DJMcNab merged 5 commits intolinebender:mainfrom Oct 21, 2024
Merged
Conversation
Philipp-M
approved these changes
Oct 20, 2024
Member
Philipp-M
left a comment
There was a problem hiding this comment.
It's really interesting, that tracing seems to have such performance impact...
Otherwise looks good.
bcec870 to
af79925
Compare
Member
Author
|
Re-requested review as I've not actioned the comment for making the trace spans include the widget's id. |
Philipp-M
approved these changes
Oct 21, 2024
Member
Philipp-M
left a comment
There was a problem hiding this comment.
Yeah that comment wasn't too important, I missed that this requires more significant changes (which obviously should be done in a follow-up PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #687, I thought some more tidying up of the log file was in order.
The main differences are:
This PR does not depend on #687