Merged
Conversation
waywardmonkeys
approved these changes
Jul 9, 2025
Contributor
waywardmonkeys
left a comment
There was a problem hiding this comment.
This looks good to me, but due to it changing things to not pass the properties around as much, I think it is best if someone else also reviews this.
PoignardAzur
approved these changes
Jul 9, 2025
Contributor
PoignardAzur
left a comment
There was a problem hiding this comment.
Very welcome change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implementing the idea discussed in #687 (comment)
The reason I didn't do this before was that I thought you needed to get the parents right. However, having re-read tracing's docs since then, I've discovered that this isn't necessary.
As discussed in bevyengine/bevy#9390, this can get you pretty close to removing all the overhead; it's possible that #687 could be undone.