Don't encode empty strokes #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
commented
Jul 10, 2025
raphlinus
approved these changes
Jul 10, 2025
Contributor
raphlinus
left a comment
There was a problem hiding this comment.
Feel free to add a test for glyph encoding.
319d0d9 to
7fc94b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #662
I was unable to isolate why this bug originally occurs (making the stroke expansion conditional on the width being non-zero appeared to work, but artificially increasing the offset didn't change anything), as I failed to find the condition mentioned in #662 (comment).
However, I was able to make the fix suggested by Chad in #662 (comment).
This fix wouldn't apply to manually created (or GPU encoded scenes), but that's pretty much fine, as we don't really support those.