Disable zeroing workgroup memory for compute shaders.#575
Merged
waywardmonkeys merged 2 commits intolinebender:mainfrom May 13, 2024
Merged
Conversation
This is a performance improvement for shader compilation. See gfx-rs/wgpu#5508
DasLixou
reviewed
May 13, 2024
DasLixou
reviewed
May 13, 2024
DJMcNab
approved these changes
May 13, 2024
Member
DJMcNab
left a comment
There was a problem hiding this comment.
I have the Default::default version running on my phone with no issues and the expected performance improvement
So once we apply that suggestion, I'm happy for this to land.
Co-authored-by: Lixou <82600264+DasLixou@users.noreply.github.com>
Collaborator
Author
|
Used the proposed change and set merge when ready as I am in bed to sleep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a performance improvement for shader compilation.
See gfx-rs/wgpu#5508