Pipeline caching! #524
Pipeline caching! #524
Conversation
34ebdd2 to
22138de
Compare
22138de to
4bb38e8
Compare
4e90142 to
9d32238
Compare
|
Not a blocker for this PR, but |
| /// # Safety | ||
| /// | ||
| /// The directory should only have been written into by [`write_pipeline_cache`]. | ||
| /// | ||
| /// We recognise that this is an impossible standard, but that's because Vulkan | ||
| /// makes UB unavoidable around invalid pipeline caches, so just do your best. |
There was a problem hiding this comment.
That's unfortunate. Can we at least embed a checksum in the cache file? If possible, one with a program-local salt so it's extra hard to get the wrong cache by accident?
There was a problem hiding this comment.
I struggle to see the point. wgpu already does some sanity checks here, and it's still possible to do UB (if something decides to write to the wrong place with a forged cache with our hash in place).
I don't believe adding it here for this example to be a good use of my time.
If you think this would be a good use of your time, there is space reserved for a hash in the header wgpu writes. The place to contribute that hashing is: https://github.com/gfx-rs/wgpu/blob/trunk/wgpu-core/src/pipeline_cache.rs. The thing that you'd need to use as salt is probably instead (most of) the data in PipelineCacheHeader
|
I'll make it non-exhaustive here. There's little advantage to splitting it out. Edit: Actually, I forgot how bad non_exhaustive is (it doesn't let you use |
a2cbd96 to
0021ec1
Compare
Supercedes #459
This is the version of pipeline caching using gfx-rs/wgpu#5319
This leads to massive improvements in startup time, especially on Android.