Skip to content

No shader runtime checks #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sagudev merged 3 commits into from
Jul 14, 2025
Merged

No shader runtime checks #1093

sagudev merged 3 commits into from
Jul 14, 2025

Conversation

@sagudev
Copy link
Contributor

@sagudev sagudev commented Jul 12, 2025

In servo I observed performance regression with #908: https://xi.zulipchat.com/#narrow/channel/197075-vello/topic/Servo.202D.20canvas.20backend/with/528398019

but disabling shader runtime checks gives it back on pre #908.

@sagudev
Trust shaders
be65d25 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev
Copy link
Contributor Author

sagudev commented Jul 12, 2025

It's https://docs.rs/wgpu/latest/wgpu/struct.ShaderRuntimeChecks.html#structfield.force_loop_bounding that makes mac fail.

waywardmonkeys
waywardmonkeys approved these changes Jul 12, 2025
View reviewed changes
Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was going to suggest the same thing.

@sagudev
Copy link
Contributor Author

sagudev commented Jul 12, 2025

There are more create_shader_module invocations in hybrid, that we could potentially trust, but this PR is focused on vello classic.

@sagudev sagudev added performance Improvements to rendering performance C-classic Applies to the classic `vello` crate labels Jul 12, 2025
@waywardmonkeys
Copy link
Collaborator

waywardmonkeys commented Jul 12, 2025

There are more create_shader_module invocations in hybrid, that we could potentially trust, but this PR is focused on vello classic.

I think I it is fine to file an issue for them to track this in hybrid.

@sagudev sagudev mentioned this pull request Jul 12, 2025
Open
DJMcNab
DJMcNab requested changes Jul 14, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to block on having a properly explained SAFETY comment here (i.e. that we only call this with shaders we have written as developers of Vello, which we believe to not have any buffer overruns)

@sagudev
safety comment
1c32b7c 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev requested a review from DJMcNab July 14, 2025 08:28
DJMcNab
DJMcNab approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In theory, each array access in the shaders and loop declaration should now have a SAFETY comment as well, but I don't think anyone has the will to actually do that

@sagudev sagudev added this pull request to the merge queue Jul 14, 2025
Merged via the queue into linebender:main with commit ecf6b28 Jul 14, 2025
17 checks passed
@sagudev sagudev deleted the trusted-sm branch July 14, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

No one assigned

Labels

C-classic Applies to the classic `vello` crate performance Improvements to rendering performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sagudev @waywardmonkeys @DJMcNab